Deleting logic for handling form data in favor of python 'requests' for the Asynchronous client #196
Conversation
| @@ -21,12 +22,9 @@ | |||
| from twisted.web.client import Agent | |||
| from twisted.web.client import FileBodyProducer | |||
| from twisted.web.http_headers import Headers | |||
| from yelp_uri import urllib_utf8 | |||
There was a problem hiding this comment.
you probably can remove the need for "yelp_uri >= 1.1.0" in setup.py
There was a problem hiding this comment.
and remove the dependency used just for debug in client.py as well
There was a problem hiding this comment.
fixed but had to port some helpers inside. still better than preventing people from using this because of yelp_uri.
| return urllib.urlencode( | ||
| [(_to_utf8(k), _to_utf8(v)) for (k, v) in _pairs(query)], | ||
| *args, **kwargs | ||
| ) |
There was a problem hiding this comment.
can we move these function to a separate module
There was a problem hiding this comment.
Actually I just found out that yelp_uri is open source https://github.com/Yelp/yelp_uri so I am putting back the dependency, anybody can use it and we don't duplicate code :)
|
👍 |
lucagiovagnoli
changed the title
|
lgtm. Can you bump the version and add an entry to changelog. should be good to merge then |
Deleting logic for handling form data in favor of python 'requests' for the Asynchronous client
|
Merged. |
fixes #194 and adds some tests for the multipart_response.py file