Don't mutate clients #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -50,34 +52,38 @@ def setup(self, request_params): | |||
| } | |||
|
|
|||
| crochet.setup() | |||
| self.eventual = self.fetch_deferred() | |||
| return self.fetch_deferred(request_params) | |||
There was a problem hiding this comment.
I wonder if this function deserves a different name name. It feels less like a setup() and more like a start_request() (or something like that).
|
LGTM, my comments are really just about further cleanup to the interface, but I think this definitely fixes the bug. Up to you how you feel about my suggested interface changes. |
|
Renamed to start_request. Made an issue for the cancel changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68 (as well as a number of other related bugs).
Requests will no longer mutate clients.
I created an integration test that actually launches a server in a separate thread... I think it might be the best way to handle it but it will of course fail if it isn't allowed to bind a port or hits a race condition binding one.