Skip to content

Commit

Permalink
🎓 Standardize do not -> don't
Browse files Browse the repository at this point in the history
  • Loading branch information
KevinHock committed Sep 19, 2019
1 parent 2648962 commit d93e9bd
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions CHANGELOG.md
Expand Up @@ -275,7 +275,7 @@ This includes using `# pragma: allowlist secret` now for inline allowlisting.

#### :telescope: Accuracy

- [Added `null` to the `FALSE_POSITIVES` tuple for the `KeywordDetector` plugin, so we do not alert off of it](https://github.com/Yelp/detect-secrets/commit/58df82ce37d64f22cb885960c2031b5f8ebe4b75)
- [Added `null` to the `FALSE_POSITIVES` tuple for the `KeywordDetector` plugin, so we don't alert off of it](https://github.com/Yelp/detect-secrets/commit/58df82ce37d64f22cb885960c2031b5f8ebe4b75)



Expand All @@ -286,7 +286,7 @@ This includes using `# pragma: allowlist secret` now for inline allowlisting.

- Turned the `KeywordDetector` plugin back on, with new regexes and accuracy improvements ([#86])
- Added an `AWSAccessKeyDetector` plugin ([#100])
- Added the ability to scan `.ini` types files that do not have a header ([#106])
- Added the ability to scan `.ini` types files that don't have a header ([#106])

[#86]: https://github.com/Yelp/detect-secrets/pull/86
[#100]: https://github.com/Yelp/detect-secrets/pull/100
Expand Down
6 changes: 3 additions & 3 deletions LICENSE
Expand Up @@ -100,21 +100,21 @@ TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
(c) You must retain, in the Source form of any Derivative Works
that You distribute, all copyright, patent, trademark, and
attribution notices from the Source form of the Work,
excluding those notices that do not pertain to any part of
excluding those notices that don't pertain to any part of
the Derivative Works; and

(d) If the Work includes a "NOTICE" text file as part of its
distribution, then any Derivative Works that You distribute must
include a readable copy of the attribution notices contained
within such NOTICE file, excluding those notices that do not
within such NOTICE file, excluding those notices that don't
pertain to any part of the Derivative Works, in at least one
of the following places: within a NOTICE text file distributed
as part of the Derivative Works; within the Source form or
documentation, if provided along with the Derivative Works; or,
within a display generated by the Derivative Works, if and
wherever such third-party notices normally appear. The contents
of the NOTICE file are for informational purposes only and
do not modify the License. You may add Your own attribution
don't modify the License. You may add Your own attribution
notices within Derivative Works that You distribute, alongside
or as an addendum to the NOTICE text from the Work, provided
that such additional attribution notices cannot be construed
Expand Down
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -178,7 +178,7 @@ committing secrets.
### Things that won't be prevented

* Multi-line secrets
* Default passwords that do not trigger the `KeywordDetector` (e.g. `login = "hunter2"`)
* Default passwords that don't trigger the `KeywordDetector` (e.g. `login = "hunter2"`)

### Plugin Configuration

Expand Down
2 changes: 1 addition & 1 deletion detect_secrets/plugins/basic_auth.py
Expand Up @@ -7,7 +7,7 @@

# This list is derived from RFC 3986 Section 2.2.
#
# We do not expect any of these delimiter characters to appear in
# We don't expect any of these delimiter characters to appear in
# the username/password component of the URL, seeing that this would probably
# result in an unexpected URL parsing (and probably won't even work).
RESERVED_CHARACTERS = ':/?#[]@'
Expand Down

0 comments on commit d93e9bd

Please sign in to comment.