replace BashColor singleton with colorize function #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinHock
reviewed
Dec 22, 2018
added 2 commits
December 21, 2018 16:24
…ect-secrets into remove-bashcolor-singleton
|
OK, had to fumble with lots of terrible git-fu because I partially rebase-merged with upstream master in the GitHub UI, then some more changes were posted to upstream since, and my local branch also wasn't synced with my fork. XD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAIK the BashColor singleton exists to toggle color enable/disable for easier testing, but it can indeed be replaced with a more lightweight and reusable
colorizefunction.Ideally, tests should be written to compare colors so the UX can be consistent - I won't be including that in this branch, and instead opted to just strip the ANSI escape sequences away for now since that was essentially what was being done before.