Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI and tox.ini: Add Python 3.7 to the testing #114

Merged
merged 3 commits into from
Jan 7, 2019

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jan 7, 2019

One warning to be aware of for Python 3.8...

=============================== warnings summary ===============================
tests/main_test.py::TestMain::test_reads_from_stdin
  /home/travis/build/Yelp/detect-secrets/.tox/py37/lib/python3.7/site-packages/yaml/constructor.py:126:
  DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
    if not isinstance(key, collections.Hashable):

Copy link
Collaborator

@KevinHock KevinHock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss strikes again :) Your PyT PRs were great. Thanks for making this.

tox.ini Show resolved Hide resolved
@KevinHock
Copy link
Collaborator

LGTM, merging now :)

@KevinHock KevinHock merged commit 795b334 into Yelp:master Jan 7, 2019
@cclauss cclauss deleted the patch-1 branch January 7, 2019 22:47
@joshuarli
Copy link
Contributor

@KevinHock @cclauss Xenial is now generally available on Travis, you should be able to have a top-level dist: xenial declaration instead of putting it in the matrix.

@cclauss
Copy link
Contributor Author

cclauss commented Jan 10, 2019

I can confirm that both solutions work. While xenial is generally available, it is not the Travis default so I usually take the more conservative route of only using it where it is needed.

@joshuarli
Copy link
Contributor

Good point, it's nice to be explicit about nondefaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants