馃悰 Fix format_baseline_for_output TypeError #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where we accidentally passed a str where we were expecting a dict :snake: Made sure to use kwargs when calling `write_baseline_to_file` Added some docstrings Added `ipdb` to `requirements-dev.txt`
domanchi
approved these changes
Jan 7, 2019
KevinHock
commented
Jan 7, 2019
KevinHock
added a commit
that referenced
this pull request
Jan 7, 2019
馃悰 Fix format_baseline_for_output TypeError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where we accidentally passed a str where we were expecting a dict
馃悕 Made sure to use kwargs when calling
write_baseline_to_fileAdded some docstrings
Added
ipdbtorequirements-dev.txt