[Keyword Plugin] Add more to FALSE_POSITIVES #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinHock
changed the title
domanchi
approved these changes
Jan 29, 2019
| @@ -62,21 +62,29 @@ | |||
| 'dummy_secret', | |||
| 'false', | |||
| 'false):', | |||
| 'false,', | |||
| 'false;', | |||
There was a problem hiding this comment.
At some point, I wonder whether it would be better to just do:
FALSE_POSITIVES = []
for key in ['false', 'none', ...]:
for suffix in [',', ';', '']:
FALSE_POSITIVES.append(key + suffix)
There was a problem hiding this comment.
I agree, I think we will at some point, a lot fp's don't have a trailing char so I'm gonna hold off until it is more battle-tested.
Also been meaning to make it a dict instead of a tuple.
KevinHock
added a commit
that referenced
this pull request
Jan 29, 2019
[Keyword Plugin] Add more to FALSE_POSITIVES
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few additions to the
FALSE_POSITIVEStuple.The only notable one is that we will not alert on
password = 'password', I felt comfortable with this because I have seen nothing but false-positives so far.