Use python instead of sed/wc during audit #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killuazhu
force-pushed
the
contribute-no-sed-wc
branch
from
4dd4b80
to
42b34b3
Compare
|
@KevinHock Travis build has passed now. Ready for a look. |
KevinHock
approved these changes
Jan 31, 2019
There was a problem hiding this comment.
Looks great to me 🚢 , thanks so much for making this @killuazhu! :D
I'll make a new release with this change tomorrow, if that's okay 👍
KevinHock
reviewed
Jan 31, 2019
|
@KevinHock thanks for accepting the PR. I'm glad it could be accepted so quick! 👍 |
* Update audit code to read files using python instead of sed/wc to align end of line character handling.
If audit is performed on a file with non-posix end of line characters then it would incorrectly extract
the line range from the file and miscalculate the index of the line the secret is on. This would result
in an error during the audit "Secret not found on line....".
The root cause of this issue was due to audit using "sed" and "wc" to extract line ranges from the file and
count total lines. When these tools encountered non-posix end of line characters they would calcaulate
different lines then via python which uses universal or cross platform end of line characters.
To ensure that it would calculate the same lines as the scan the audit code has been updated to use
python to read the original file and extract the specified lines.
killuazhu
force-pushed
the
contribute-no-sed-wc
branch
from
4d5ab73
to
7b312cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update audit code to read files using python instead of sed/wc to align the end of line character handling.
If the audit is performed on a file with non-posix end of line characters then it would incorrectly extract the line range from the file and miscalculate the index of the line the secret is on. This would result in an error during the audit "Secret not found on line....".
The root cause of this issue was due to audit using "sed" and "wc" to extract line ranges from the file and count total lines. When these tools encountered the non-posix end of line characters they would calculate different lines then via python which uses a universal or cross-platform end of line characters.
To ensure that it would calculate the same lines as the scan the audit code has been updated to use python to read the original file and extract the specified lines.
CC @jribm