Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Keyword detector accuracy for .cls and .yaml files #133

Merged
merged 3 commits into from
Mar 20, 2019

Conversation

KevinHock
Copy link
Collaborator

πŸ”­ [Keyword Plugin] Add cls and yaml special cases …
Require quotes in .cls files
Skip secrets starting with {{ and ending with }} in yaml files
🐍 [Keyword Plugin] Add test using keyword_exclude
πŸŽ“ [Usage] Minor nits …
Add period to end of all help strings
Formatting in usage_test.py

Require quotes in .cls files
Skip secrets starting with {{ and ending with }} in yaml files
Add period to end of all help strings
Formatting in usage_test.py
@KevinHock
Copy link
Collaborator Author

KevinHock commented Mar 14, 2019

TODO: Make quotes required for .java files as well Done in fe3e989

TODO: Add to FALSE_POSITIVES:
- > for Ruby e.g. :some_password => params[some_thing]
- "dummy for e.g. "dummy value"
- :: (from an internal test case)
- null.*' (from an internal test case) Done in 2f21d3d

@KevinHock KevinHock merged commit 1afb05f into master Mar 20, 2019
@KevinHock KevinHock deleted the keyword_detector_accuracy_cls_yaml branch March 21, 2019 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant