Patch backports configparser too #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously patched configparser with `EfficientParsingError`, however this did not patch the backports version present on Python 2.
|
Hi @jaraco, just curious, why is it necessary to do a |
|
It’s just that the backport exists as backports.configparser and that’s the only way to reliably get the backport, because if you import configparser, you’ll get the stdlib version of present or the backport otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Patch backports configparser too
We previously 🐒 patched configparser with
EfficientParsingErrorto fix #136, however this did not patch the backports version present on Python 2.The configparser README says
If you’d like to use the backport on Python 2 and the built-in version on Python 3, then use the invocation that we were using, i.e.import configparser. However this doesn't work when monkey-patching, so I did the more explicitfrom backports import configparser.