Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[private key plugin] Change analyze_string output dict #15

Merged
merged 2 commits into from
Apr 6, 2018
Merged

[private key plugin] Change analyze_string output dict #15

merged 2 commits into from
Apr 6, 2018

Conversation

KevinHock
Copy link
Collaborator

To have PotentialSecret as the key, not filename.

Please see #14 for a more in-depth issue description.

@KevinHock KevinHock requested a review from domanchi April 6, 2018 21:41
domanchi
domanchi approved these changes Apr 6, 2018
View reviewed changes
Copy link
Contributor

@domanchi domanchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're changing this, probably can remove the comment in analyze.

@KevinHock KevinHock merged commit ccc60fd into master Apr 6, 2018
@KevinHock KevinHock deleted the 14_fix_private_key_analyze_string branch April 6, 2018 21:51
jimmyhlee94 pushed a commit to jimmyhlee94/detect-secrets that referenced this pull request Aug 19, 2021
@victoria-miltcheva
Merge pull request Yelp#15 from victoria-miltcheva/sync-to-dss
30c8eb0 
Sync branches and tags with IBM detect-secrets repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domanchi domanchi domanchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KevinHock @domanchi