Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds artifactory credential detector to plugins #157

Merged
merged 6 commits into from
Apr 9, 2019

Conversation

justineyster
Copy link

Supports #156

Copy link
Collaborator

@KevinHock KevinHock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me, just left one nit

detect_secrets/plugins/common/initialize.py Outdated Show resolved Hide resolved
@KevinHock KevinHock merged commit 694e310 into Yelp:master Apr 9, 2019
justineyster added a commit to justineyster/detect-secrets that referenced this pull request Apr 18, 2019
Follow up of Yelp#157. Adds feature to catch an artifactory secret after a colon, such as in a yaml file context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants