Handling yaml files #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 9, 2018 12:18
KevinHock
approved these changes
Apr 9, 2018
| @@ -0,0 +1,9 @@ | |||
| credentials: | |||
There was a problem hiding this comment.
What are your thoughts on badly formatted YAML files? If I'm reading the code right the line-numbers won't be correct but maybe we decide it doesn't matter that much.
e.g.
repos: [
{repo: ..., sha: ..., hooks: [{id: ...}]},
]| @@ -110,6 +128,44 @@ def _analyze_ini_file(self, file, filename): | |||
|
|
|||
| return potential_secrets | |||
|
|
|||
| def _analyze_yaml_file(self, file, filename): | |||
| """ | |||
| :returns: same format as super().analyze() | |||
There was a problem hiding this comment.
Nit: Maybe add e.g. :raises: yaml.YAMLError and the same w/ configparser.Error to _analyze_ini_file.
jimmyhlee94
pushed a commit
to jimmyhlee94/detect-secrets
that referenced
this pull request
Aug 19, 2021
…ting Troubleshooting deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2/2 for the fix to: #12