Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle golang string assignments #162

Merged
merged 5 commits into from
Apr 12, 2019
Merged

handle golang string assignments #162

merged 5 commits into from
Apr 12, 2019

Conversation

baboateng
Copy link
Contributor

Support for string assignments in golang, currently detect secrets will catch:

password = ewijeiwbf98th9u4bgi4ub49uigbigj
password:ewijeiwbf98th9u4bgi4ub49uigbigj

but golang short assignments, support doing

password := "ewijeiwbf98th9u4bgi4ub49uigbigj"

@KevinHock KevinHock self-requested a review April 12, 2019 17:14
KevinHock
KevinHock approved these changes Apr 12, 2019
View reviewed changes
Copy link
Collaborator

@KevinHock KevinHock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, awesome stuff! Code is perfect 👏 😎

@KevinHock KevinHock merged commit f2b06c3 into Yelp:master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinHock KevinHock KevinHock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@baboateng @KevinHock