Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for text after whitelist #168

Merged

Conversation

dgzlopes
Copy link
Contributor

@dgzlopes dgzlopes commented May 9, 2019

Signed-off-by: Daniel González Lopes danielgonzalezlopes@gmail.com

Minor fix for #117. Added a couple of testing cases too!

Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
@KevinHock KevinHock self-requested a review May 9, 2019 22:26
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Copy link
Collaborator

@KevinHock KevinHock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚢

@KevinHock KevinHock merged commit dd4de73 into Yelp:master May 10, 2019
@dgzlopes dgzlopes deleted the fix-117-whitelist-additional-text-support branch May 13, 2019 18:38
killuazhu pushed a commit to IBM/detect-secrets that referenced this pull request May 28, 2020
killuazhu pushed a commit to IBM/detect-secrets that referenced this pull request Jul 9, 2020
killuazhu pushed a commit to IBM/detect-secrets that referenced this pull request Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants