Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better handling for ini parsing #17

Merged
merged 1 commit into from
Apr 16, 2018
Merged

better handling for ini parsing #17

merged 1 commit into from
Apr 16, 2018

Conversation

domanchi
Copy link
Contributor

Bug fix to #12.

@domanchi domanchi requested a review from KevinHock April 13, 2018 03:01
Copy link
Collaborator

@KevinHock KevinHock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


def __init__(self, file):
self.parser = configparser.ConfigParser()
self.parser.optionxform = str
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to keep case, I'm assuming?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup.

@domanchi domanchi merged commit 206ec76 into master Apr 16, 2018
@domanchi domanchi deleted the ini-parser-bug-fix branch April 17, 2018 03:31
jimmyhlee94 pushed a commit to jimmyhlee94/detect-secrets that referenced this pull request Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants