Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing XML style #172

Merged
merged 1 commit into from
May 10, 2019
Merged

Fix missing XML style #172

merged 1 commit into from
May 10, 2019

Conversation

dgzlopes
Copy link
Contributor

Signed-off-by: Daniel Gonz谩lez Lopes danielgonzalezlopes@gmail.com

Fix missing XML language from #165. Closed #171 in favor of this one (Bad branch name! 馃槗).

Signed-off-by: Daniel Gonz谩lez Lopes <danielgonzalezlopes@gmail.com>
@dgzlopes dgzlopes changed the title Fix missing XML Fix missing XML comment style May 10, 2019
@dgzlopes dgzlopes changed the title Fix missing XML comment style Fix missing XML style May 10, 2019
Copy link
Collaborator

@KevinHock KevinHock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 馃殺

@KevinHock KevinHock merged commit 458d7e9 into Yelp:master May 10, 2019
@dgzlopes dgzlopes deleted the fix-missing-xml branch May 13, 2019 18:38
killuazhu pushed a commit to killuazhu/detect-secrets that referenced this pull request Oct 18, 2019
* get_username function

* Adapt regex

* Add username regex

* Complete 'get_username()' function

* Softlayer verify function

* First attempt at tests

* Finished writing tests

* Address @edwarj2 PR comments

* Address PR comments 1

* Address PR comments 2

* Address PR comments 3

* Valid if status_code=200
killuazhu pushed a commit to killuazhu/detect-secrets that referenced this pull request Oct 18, 2019
* get_username function

* Adapt regex

* Add username regex

* Complete 'get_username()' function

* Softlayer verify function

* First attempt at tests

* Finished writing tests

* Address @edwarj2 PR comments

* Address PR comments 1

* Address PR comments 2

* Address PR comments 3

* Valid if status_code=200
killuazhu pushed a commit to IBM/detect-secrets that referenced this pull request May 28, 2020
* get_username function

* Adapt regex

* Add username regex

* Complete 'get_username()' function

* Softlayer verify function

* First attempt at tests

* Finished writing tests

* Address @edwarj2 PR comments

* Address PR comments 1

* Address PR comments 2

* Address PR comments 3

* Valid if status_code=200
killuazhu pushed a commit to IBM/detect-secrets that referenced this pull request Jul 9, 2020
* get_username function

* Adapt regex

* Add username regex

* Complete 'get_username()' function

* Softlayer verify function

* First attempt at tests

* Finished writing tests

* Address @edwarj2 PR comments

* Address PR comments 1

* Address PR comments 2

* Address PR comments 3

* Valid if status_code=200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants