Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RegexBasedDetector plugin docs #177

Merged

Conversation

dgzlopes
Copy link
Contributor

Signed-off-by: Daniel González Lopes danielgonzalezlopes@gmail.com

I think this might be an improvement (al least for now) as said on #170. On the other hand, sometimes my english is a little blurry! So any improvements are welcome.

Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Copy link
Collaborator

@KevinHock KevinHock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KevinHock KevinHock merged commit 1f3322c into Yelp:master May 16, 2019
@dgzlopes dgzlopes deleted the docs-170-improve-regex-detectors-listing branch May 16, 2019 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants