Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update pre-commit hook versions #221

Merged
merged 4 commits into from
Aug 14, 2019

Conversation

killuazhu
Copy link
Contributor

Update pre-commit hook plugin versions.

Copy link
Collaborator

@KevinHock KevinHock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢, thanks Kyle! 🙏

@KevinHock
Copy link
Collaborator

Oh, it seems you need to run the trailing comma pre-commit hook in order to get Travis to pass

@killuazhu
Copy link
Contributor Author

@KevinHock updated, Travis is passing now.

@KevinHock KevinHock merged commit 99528d4 into Yelp:master Aug 14, 2019
@KevinHock
Copy link
Collaborator

Thanks 🙏😊

killuazhu pushed a commit to killuazhu/detect-secrets that referenced this pull request Oct 28, 2019
* Fix Cloud IAM detector bug

* Test the failing syntax apikey:<key>

* Make ibm cloud iam keywords optional
killuazhu pushed a commit to IBM/detect-secrets that referenced this pull request May 28, 2020
* Fix Cloud IAM detector bug

* Test the failing syntax apikey:<key>

* Make ibm cloud iam keywords optional
killuazhu pushed a commit to IBM/detect-secrets that referenced this pull request Jul 9, 2020
* Fix Cloud IAM detector bug

* Test the failing syntax apikey:<key>

* Make ibm cloud iam keywords optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants