Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyword Plugin] Various accuracy improvements #229

Merged
merged 6 commits into from
Aug 24, 2019

Commits on Aug 22, 2019

  1. Configuration menu
    Copy the full SHA
    646c1e0 View commit details
    Browse the repository at this point in the history
  2. πŸ”­ [Keyword Plugin] Remove FP heuristics for JS

    These are no longer necessary as we made quotes required in the last
    commit.
    KevinHock committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    85f0c74 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2019

  1. πŸ”­ [Keyword Plugin] Add custom regex for Obj-C

    - 🐍 Alphabetize variables
    - 🐍 Replace `elif` chain with a dict
    - 🐍 Update QUOTES_REQUIRED_FILE_EXTENSIONS in the test
    KevinHock committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    04c6d34 View commit details
    Browse the repository at this point in the history
  2. πŸ”­ [Keyword Plugin] Add format strings FP heuristic

    e.g. "secret": "{secret}"
    
    - Change keyword test to not have the positives start with { and end with }
    - 🐍 Make .pyi files have FileType.PYTHON
    KevinHock committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    2f2ccb0 View commit details
    Browse the repository at this point in the history
  3. πŸ”­ [Keyword Plugin] Accuracy improvements

    - Add FP check for '/etc/' in secret
    - Add FP heuristic for secrets that look like directories
    - Add <secret> FP heuristic for .example files
    - Add more to FALSE_POSITIVES dict
    - Make all non-quotes required filetypes skip secrets starting with a $
    - Make quotes required for Terraform files
    KevinHock committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    a53d12e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5de43e2 View commit details
    Browse the repository at this point in the history