Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Verifiability Slack #233

Merged
merged 2 commits into from
Sep 4, 2019
Merged

Added Verifiability Slack #233

merged 2 commits into from
Sep 4, 2019

Conversation

Patil2099
Copy link
Contributor

Fixes #232

@KevinHock
Copy link
Collaborator

KevinHock commented Aug 28, 2019

Thanks for making this!

From reading Travis CI, it seems the tests all pass, just that the pre-commit checks are failing, sorry I didn’t mention those in the issue.

For this you can do
pip install pre-commit
pre-commit run —all-flies

Certain hooks fix files for you while others will just fail, it seems like the ones failing currently will fix the file for you.

After you run the 2 commands above you can git add the files and push a new commit 👍

@Patil2099
Copy link
Contributor Author

@KevinHock the test is still failing

@KevinHock
Copy link
Collaborator

KevinHock commented Aug 30, 2019

Were you able to run the hooks? It seems they are still modifying files.

@Patil2099
Copy link
Contributor Author

@KevinHock Sorry I was not able to run the hook.

Copy link
Collaborator

@KevinHock KevinHock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚢

@KevinHock
Copy link
Collaborator

No worries @Patil2099

@OiCMudkips can you merge this when you get a chance and run the hooks right after? Alternatively, I can do it once I'm back.

@OiCMudkips OiCMudkips merged commit c38a437 into Yelp:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add verifiability for Slack webhooks
3 participants