Create plugin to detect Twilio API keys. #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit contains a RegexBasedDetector plugin for Twilio API keys.
Twilio's API requires an "Account SID" and "auth token" which can be
detected by this plugin using two regular expressions.
Example account SID: ACxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
Regex: AC[a-z0-9]{32}
Example auth token: SKxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
Regex: SK[a-z0-9]{32}
It might be worth further expanding this plugin to include a verify
function that sends a GET request to
{}:{}@api.twilio.com/2010-04-01/Accounts.json.
domanchi
reviewed
Nov 10, 2019
I was importing packages that weren't used in twilio.py. This commit removes those import statements.
domanchi
approved these changes
Nov 11, 2019
tests/plugins/twilio_test.py
Outdated
| def test_analyze(self, payload, should_flag): | ||
| logic = TwilioKeyDetector() | ||
| output = logic.analyze_line(payload, 1, 'mock_filename') | ||
| assert len(output) == int(should_flag) |
There was a problem hiding this comment.
Probably can just do:
assert output
as that will make sure that it is a non-empty dictionary.
|
@domanchi, do you think we should add some form of key verification or just leave it as is? |
|
Just realized it's @EdOverflow :) Thank you for contributing! |
|
:) |
Naw. Key verification can always be done at a later iteration. :) |
killuazhu
pushed a commit
to IBM/detect-secrets
that referenced
this pull request
May 28, 2020
killuazhu
pushed a commit
to IBM/detect-secrets
that referenced
this pull request
Jul 9, 2020
killuazhu
pushed a commit
to IBM/detect-secrets
that referenced
this pull request
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains a
RegexBasedDetectorplugin for Twilio API keys. Twilio's API requires an "account SID" and "auth token" which can be detected by this plugin using two regular expressions.It might be worth further expanding this plugin to include a verify function that sends a GET request to
{}:{}@api.twilio.com/2010-04-01/Accounts.json.