Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not every company has a #security channel in slack/irc #283

Merged
merged 5 commits into from
Mar 11, 2020

Conversation

0atman
Copy link
Contributor

@0atman 0atman commented Mar 9, 2020

For information about putting your secrets in a safer place, please ask in #security

For us, in @alphagov, our #security channel is for physical security questions and our cyber security team hang out in #cybersecurity.

This seems like the simplest way to get the message changed, working even for people who don't - or can't - use a config.

My edits formatted with black
EDIT: They're now linted by flake8, in accordance with the CI.

For us, in @alphagov, our #security channel is for physical security questions and our cyber security team hang out in #cybersecurity.

This seems like the simplest way to get the message changed, working even for people who don't - or can't - use a config.

My edits formatted with [black](https://github.com/psf/black)
For example
Copy link
Collaborator

@KevinHock KevinHock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛵️

Looks great to me, thanks for making this!

@KevinHock KevinHock merged commit 79dad49 into Yelp:master Mar 11, 2020
@0atman
Copy link
Contributor Author

0atman commented Mar 11, 2020

Thanks @KevinHock! What a treat. Is there anything else I can help with in regard to getting this into the next release?

@KevinHock
Copy link
Collaborator

No, thank you though 👍

It’ll automatically be in the next release, maybe the week after next.

@0atman
Copy link
Contributor Author

0atman commented Mar 12, 2020

Brilliant! What a pleasure, thank you.

@0atman 0atman deleted the patch-1 branch March 12, 2020 11:51
@KevinHock
Copy link
Collaborator

Hi @0atman, just wanted to let you know that there was a new release, v13.0.1 https://github.com/Yelp/detect-secrets/blob/master/CHANGELOG.md#v0131, with your changes in it.

Cheers,
-Kevin

@0atman
Copy link
Contributor Author

0atman commented Mar 30, 2020

Thank you so much! It works for me, I'll roll it out to our install 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants