Supporting multiword adhoc string scans #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinHock
approved these changes
Mar 25, 2020
lgtm| round(self.calculate_shannon_entropy(string), 3), | ||
| round( | ||
| self.calculate_shannon_entropy( | ||
| list(results.keys())[0].secret_value, |
There was a problem hiding this comment.
Nit: Maybe add a # There can only be 1 secret in the results comment
domanchi
force-pushed
the
multiword-string-scan
branch
from
849ebaa
to
2dce336
Compare
killuazhu
pushed a commit
to IBM/detect-secrets
that referenced
this pull request
May 28, 2020
Supports git-defenders/detect-secrets-discuss#390
killuazhu
pushed a commit
to IBM/detect-secrets
that referenced
this pull request
Jul 9, 2020
Supports git-defenders/detect-secrets-discuss#390
killuazhu
pushed a commit
to IBM/detect-secrets
that referenced
this pull request
Sep 17, 2020
Supports git-defenders/detect-secrets-discuss#390
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
I wanted to perform an adhoc scan for a line of code, using the
scan --stringoption. However, I came across this strange behavior:Solution
Support multi-word scans through this functionality. We maintain strict backwards compatibility, so this should be a sole addition. There may be some confusion as to what the entropy value returned from a multi-word string refers to, but it seems like this is a better option than adding another
--linefunctionality to handle this case.