Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminate token matching #289

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Conversation

killuazhu
Copy link
Contributor

Fixes #288

Terminate the string matching after required number of characters.

@killuazhu
Copy link
Contributor Author

@domanchi added a fix for the issue #288 you raised.

Copy link
Contributor

@domanchi domanchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@domanchi domanchi merged commit bfe735b into Yelp:master Mar 27, 2020
killuazhu pushed a commit to IBM/detect-secrets that referenced this pull request May 28, 2020
* Use unverified by default, only report false for true neg

* Still use 5s as timeout
killuazhu pushed a commit to IBM/detect-secrets that referenced this pull request Jul 9, 2020
* Use unverified by default, only report false for true neg

* Still use 5s as timeout
killuazhu pushed a commit to IBM/detect-secrets that referenced this pull request Sep 17, 2020
* Use unverified by default, only report false for true neg

* Still use 5s as timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IBM COS HMAC Detector False Positives?
2 participants