💥 Drop Python 2 support #292

KevinHock · 2020-03-30T23:23:05Z

💥

There may be some leftovers regarding Bytes/Unicode like from #223 and there is

Lines 24 to 27 in 9d8fe79

    
           # We need to use a dictionary, because python2.7 does not support 
        
           # the `nonlocal` keyword (and needs to share scope with 
        
           # _mock_single_git_call function) 
        
           current_case = {'index': 0}

But, those seem like good-first-issues or things we can clean up later. Didn't want to spend much time on this tbh.

- Remove python2 from setup.py

We do not use it internally.

From commit a3e7998

domanchi

LGTM. Please make sure that this goes in a breaking change version bump.

KevinHock added 5 commits March 27, 2020 17:16

🐍 Add pypy -> pypy3 in .travis.yml

3e39b76

💥 Only python3 pre-commit hook

00b9bf8

- Remove python2 from setup.py

🐍 Remove unused filename_key argument

7c32918

🐍 Pythonic use of or

6ec6f43

🐍 Remove all __future__ imports

5d0d461

KevinHock requested review from OiCMudkips and domanchi March 30, 2020 23:23

KevinHock added 5 commits March 30, 2020 16:24

💥 Drop pypy support

141819d

We do not use it internally.

🎓 Fix link in CHANGELOG

76bcb64

From commit a3e7998

🐍 Normalize lru_cache and configparser imports

7046220

🐍 Remove is_python_2 func and uses

0e1dd3f

🐍 Remove all code with "Python 2 compat" comments

05727d2

KevinHock force-pushed the python3 branch from 6806cc0 to 05727d2 Compare March 30, 2020 23:25

domanchi mentioned this pull request Mar 31, 2020

Deprecate Python 2 support? #260

Closed

domanchi approved these changes Mar 31, 2020

View reviewed changes

KevinHock merged commit d94b92f into master Mar 31, 2020

KevinHock deleted the python3 branch March 31, 2020 17:53

KevinHock mentioned this pull request Apr 4, 2020

Various small improvements #293

Merged

killuazhu pushed a commit to IBM/detect-secrets that referenced this pull request May 28, 2020

Catch api_key for SL token (Yelp#292)

ecca6c2

killuazhu pushed a commit to IBM/detect-secrets that referenced this pull request Jul 9, 2020

Catch api_key for SL token (Yelp#292)

985232f

killuazhu pushed a commit to IBM/detect-secrets that referenced this pull request Sep 17, 2020

Catch api_key for SL token (Yelp#292)

c05daa5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

💥 Drop Python 2 support #292

💥 Drop Python 2 support #292

KevinHock commented Mar 30, 2020

domanchi left a comment

	# We need to use a dictionary, because python2.7 does not support
	# the `nonlocal` keyword (and needs to share scope with
	# _mock_single_git_call function)
	current_case = {'index': 0}

💥 Drop Python 2 support #292

💥 Drop Python 2 support #292

Conversation

KevinHock commented Mar 30, 2020

domanchi left a comment

Choose a reason for hiding this comment