Slack Plugin bug fixes #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinHock
approved these changes
Aug 8, 2020
KevinHock
reviewed
Aug 9, 2020
There was a problem hiding this comment.
Do you mind adding a test case to show what these URLs look like for posterity?
https://github.com/Yelp/detect-secrets/blob/master/tests/plugins/slack_test.py#L35
|
Example of a webhook url (which I disabled immediately after creating) : https://hooks.slack.com/services/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 The original regex failed because the second secret part of the URL (starting with B) has 10 characters after the B, and not 8. |
killuazhu
pushed a commit
to IBM/detect-secrets
that referenced
this pull request
Sep 17, 2020
We were getting report that slack custom application webhook will contain a different foramt for webhooks. In particualar the B+8 chars could become B+10 chars format User reprot https://ibm-cio-gi.slack.com/archives/CDMGJ9QG2/p1591018601323500?thread_ts=1590777088.301300&cid=CDMGJ9QG2 We also noticed the response error message is differnet, this commit tried to address that issue and allow us to catch webhook for custom Slack applications
jimmyhlee94
pushed a commit
to jimmyhlee94/detect-secrets
that referenced
this pull request
Aug 19, 2021
We were getting report that slack custom application webhook will contain a different foramt for webhooks. In particualar the B+8 chars could become B+10 chars format User reprot https://ibm-cio-gi.slack.com/archives/CDMGJ9QG2/p1591018601323500?thread_ts=1590777088.301300&cid=CDMGJ9QG2 We also noticed the response error message is differnet, this commit tried to address that issue and allow us to catch webhook for custom Slack applications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the slack webhooks regex to support longer urls which didn't match the existing one.
Also, added 'no_text' as a valid response.text. Without it some valid urls hasn't been marked as verified and didn't appear in the baseline at all