Fix adhoc scan verify #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 27, 2020 11:40
domanchi
reviewed
Aug 27, 2020
| @@ -239,7 +239,7 @@ def adhoc_scan(self, string): | |||
|
|
|||
| return output[verified_result] | |||
|
|
|||
| def verify(self, token, content=''): | |||
There was a problem hiding this comment.
It's actually meant to be context.
A couple of lines down, it reads:
:param context: lines of context around identified secret
There was a problem hiding this comment.
Right, that's why I renamed it to context.
There was a problem hiding this comment.
🤦 I must be getting cross-eyed.
domanchi
approved these changes
Aug 27, 2020
jimmyhlee94
pushed a commit
to jimmyhlee94/detect-secrets
that referenced
this pull request
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
self.verifycall was missing a parameter in the adhoc string scanning function. This PR adds the missing parameter.Also, I noticed that a parameter name for
verifywas misnamed. I fixed that in this PR too.