Fix "pre-commit hook removes plugins from baseline" #40
Conversation
…o plugin_type_limit, and from list to float, use **kwargs not *args
…kwargs, and change _convert_sensitivity_values_to_class_tuple to match
|
|
||
| plugins = [] | ||
| for plugin in data['plugins_used']: | ||
| plugin_classname = plugin.pop('name') |
There was a problem hiding this comment.
I'm so glad I finally got to use pop (cc @omergunal)
| if not all(key in data for key in ( | ||
| 'exclude_regex', | ||
| 'results', | ||
| 'plugins_used' |
There was a problem hiding this comment.
This is gonna be a "breaking" change, because plugins_used was only introduced "recently". Then again, as long as we bundle this with #38 before wrapping it up as a version, it should be OK.
There was a problem hiding this comment.
Added the requirement of version in my merge with master, which definitely breaks (3 months ago plugins_used was added vs. version just added today.) 👍
| @@ -210,13 +210,13 @@ def _add_custom_limits(self): | |||
| self.parser.add_argument( | |||
| '--base64-limit', | |||
| type=self._argparse_minmax_type, | |||
| nargs=1, | |||
| nargs='?', | |||
There was a problem hiding this comment.
What does it mean to have --base64-limit without any limit?
There was a problem hiding this comment.
I'm not sure I follow, do you mean if I do python -m detect_secrets.main --base64-limit --scan test_secrets/? It uses the default.
detect_secrets/plugins/__init__.py
Outdated
| @@ -145,7 +141,7 @@ def _convert_sensitivity_values_to_class_tuple(sensitivity_values): | |||
| This way, we can initialize the class with <plugin_class_name>(<value>) | |||
|
|
|||
| Example: | |||
| >>> [ ('HexHighEntropyString', 3), ('PrivateKeyDetector', true), ] | |||
| >>> [ ('HexHighEntropyString', {'hex_limit': 3}), ('PrivateKeyDetector', {'private_key_detector': true}), ] | |||
There was a problem hiding this comment.
please shorten this line. =)
Maybe,
>>> [
... ('HexHighEntropyString', {'hex_limit': 3}),
... ('PrivateKeyDetector', {'private_key_detector': true}),
... ]
?
To make it easier, I will adjust E501 settings for the future.
This fixes the issue @LouisTrezzini reported in #32 where we would not read in or output plugin information when reading a baseline from the pre-commit hook code.