bug fix: upgrading from v0.12-0.14 incorrectly handles exclude_regex #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvinli
approved these changes
Apr 8, 2021
killuazhu
pushed a commit
to IBM/detect-secrets
that referenced
this pull request
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suboptimal patch, but is the best that we can do.
In older versions, it looks like
exclude_regexdeals with files, not lines (source). This change modifies the auto-upgrade script to handle this properly for all other users who haven't upgraded yet.However, for those users who upgraded their baselines between <0.12 and =~1.0, they will need to apply the change manually. This is because once this change has been made, we cannot assume that the regex that applies to lines should have been applied to files (as new☹️
--exclude-lineregexes could have been applied). As such, there's no automated manner to upgrade this.Kudos to @calvinli for finding this one.