Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a plugin for SendGrid #463

Merged
merged 1 commit into from
Aug 1, 2021
Merged

Conversation

ninoseki
Copy link
Contributor

Add a plugin for SendGrid API key detection (#462)

Copy link
Collaborator

@KevinHock KevinHock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for making this!


denylist = [
# SendGrid API key
# ref. https://d2w67tjf43xwdp.cloudfront.net/Classroom/Basics/API/what_is_my_api_key.html
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case https://d2w67tjf43xwdp.cloudfront.net looks odd to someone reading this, I tried Google-foo'ing and got the same.

https://docs.sendgrid.com/ui/account-and-settings/api-keys doesn't give an example.

@KevinHock KevinHock merged commit 3f806f1 into Yelp:master Aug 1, 2021
@ninoseki ninoseki deleted the add-plugin-for-sendgrid branch August 2, 2021 01:34
@ninoseki
Copy link
Contributor Author

ninoseki commented Aug 2, 2021

@KevinHock Sorry for providing the URL of non-official website.
Just a note, here is an evidence to validate the pattern for SendGrid API key. (I masked most of the part. So it might be not persuadable 😉)

SendGrid

killuazhu pushed a commit to IBM/detect-secrets that referenced this pull request Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants