Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #472 #476

Merged
merged 2 commits into from
Aug 1, 2021
Merged

Fix #472 #476

merged 2 commits into from
Aug 1, 2021

Conversation

KevinHock
Copy link
Collaborator

@KevinHock KevinHock commented Aug 1, 2021 •
edited
Loading

Mainly fixes #472, my bad for merging that, didn't realize Travis CI was gone.

    :snake:Prettify a few lines
    
    Add start keyword to enumerate argument
    set([]) -> set()

...

    :bug:Fix .get to be getattr
    
    PotentialSecret is not a dictionary, so do getattr and not .get
    Fixes #472

@KevinHock
🐛Fix .get to be getattr
7e14cda 
PotentialSecret is not a dictionary, so do getattr and not .get
Fixes #472
@KevinHock
🐍Prettify a few lines
dd13fe7 
Add start keyword to enumerate argument
set([]) -> set()
@KevinHock KevinHock merged commit fefc670 into master Aug 1, 2021
@KevinHock KevinHock deleted the fix_472 branch August 1, 2021 20:36
@js-truework
Copy link
Contributor

Sorry for the .get usage! I actually realized much later that night that I probably needed to use getattr and then I got caught up with work and didn't circle back in time to catch it before the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KevinHock @js-truework