audit bug fix: handles short files better #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinHock
approved these changes
Jul 3, 2018
| @@ -441,15 +442,7 @@ def test_input_message(self, prompt_secret_decision, expected_output): | |||
|
|
|||
| @pytest.fixture | |||
| def mock_printer(): | |||
There was a problem hiding this comment.
Super nit: Maybe consider renaming to avoid the name conflict/alias of the mock_printer
import, e.g. mock_audit_printer or something. (Makes grep'ing a little easier.)
| BashColor.disable_color() | ||
|
|
||
| with mock_stdin(), mock_printer( | ||
| # To extract the baseline output |
There was a problem hiding this comment.
Great mock.patch comments!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our default
lines_of_contextwhen printing the interactive auditor is 5. However, when there isn't five lines to print, we can find ourselves in a strange case: the auditor doesn't know how to handle it so it either:a) throws an IndexError exception (if
abs(-lines_of_context -1 ) > len(output)), ORb) displays a
ERROR: Secret not found on specified line number!So let's handle this better.