Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Catastophic Backtracking for Indirect Reference #509

Merged
merged 3 commits into from
Feb 2, 2022
Merged

Fix Catastophic Backtracking for Indirect Reference #509

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a5764c
Update regex to avoid catastrophic backtracking
jpdakran Feb 1, 2022
4ad4b69
Merge remote-tracking branch 'origin/master' into jdakran_fix_catastr…
jpdakran Feb 2, 2022
f0351f2
Keep regex the same. Only run heuristic for lines that are less than …
jpdakran Feb 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions detect_secrets/filters/heuristic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,8 @@ def is_indirect_reference(line: str) -> bool:

secret = request.headers['apikey']
"""
if len(line) > 1000:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpdakran : we should document design rationales in code to assist future developers in understanding the codebase.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood. Please see #516 for update.

return False
return bool(_get_indirect_reference_regex().search(line))


Expand Down