Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make is_likely_id_string More Strict #526

Merged
merged 5 commits into from
Apr 13, 2022

Conversation

jpdakran
Copy link
Member

Issue: 489

Problem:

  • The is_likely_id_string regex can eliminate true positives by mistake.
  • Ex. Anything ending in id like the name david followed by a non-letter/non-numeric character will match

Solution:

  • Make the regex more strict to identify id strings.
  • This can be achieved by enforcing the string starts with the id identifier however we lose out on the other typical id_string identifiers like myid, userid etc.
  • We can enforce these additional identifiers
  • Also enforce the _id identifier and this can exist in the middle of a string

Copy link
Member

@lorenzodb1 lorenzodb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants