Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding --all-files flag #57

Merged
merged 1 commit into from
Jul 12, 2018
Merged

adding --all-files flag #57

merged 1 commit into from
Jul 12, 2018

Conversation

domanchi
Copy link
Contributor

Testing

detect-secrets scan --all-files

This allows the extended usage of this tool, so we can scan non-git tracked files as well on an adhoc manner.

@domanchi domanchi requested a review from KevinHock July 11, 2018 00:22
Copy link
Collaborator

@KevinHock KevinHock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

This function allows us to do so.
"""
output = []
for root, dirs, files in os.walk(rootdir):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nit: you can use _ for dirs

@domanchi domanchi merged commit 3ff7bf2 into master Jul 12, 2018
@domanchi domanchi deleted the add-all-files-flag branch July 12, 2018 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants