Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add py.typed file to enable type hints for package consumers #579

Merged
merged 2 commits into from
Jul 18, 2022
Merged

add py.typed file to enable type hints for package consumers #579

merged 2 commits into from
Jul 18, 2022

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Jul 9, 2022

Just added the missing py.typed file. So other projects, which add the project as a library will benefit from the inline type hints. Without this file type checkers, like mypy, think the whole project is untyped. And also added the Typed classifier to make it searchable in pypi 馃檪 great work by the way 馃殌

@gruebel
Copy link
Contributor Author

gruebel commented Jul 11, 2022

@jpdakran fixed the lint issues. Didn't expect you are checking the setup.py 馃槃

Copy link
Member

@jpdakran jpdakran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤 Thanks for your contribution.

@jpdakran jpdakran merged commit f0cc7b8 into Yelp:master Jul 18, 2022
@gruebel gruebel deleted the add-pytyped branch July 18, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants