Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More intelligent upgrade of baselines #58

Merged
merged 2 commits into from
Jul 11, 2018
Merged

More intelligent upgrade of baselines #58

merged 2 commits into from
Jul 11, 2018

Conversation

domanchi
Copy link
Contributor

@domanchi domanchi commented Jul 11, 2018

Testing

$ detect-secrets scan --update .secrets.baseline

Easier to use, and more accurate than

$ detect-secrets scan < .secrets.baseline > .secrets.baseline.new
$ mv .secrets.baseline.new .secrets.baseline

Fixes #55

@domanchi domanchi requested a review from KevinHock July 11, 2018 00:57
Copy link
Collaborator

@KevinHock KevinHock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nargs=1,
metavar='OLD_BASELINE_FILE',
help='Import settings from previous existing baseline.',
help='Update existing baseline by import settings from it.',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: importing

@domanchi domanchi merged commit 80e2398 into master Jul 11, 2018
@domanchi domanchi deleted the smarter-import branch July 11, 2018 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants