Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET packages.lock.json to is_lock_file filter #593

Merged
merged 4 commits into from
Aug 25, 2022
Merged

Add .NET packages.lock.json to is_lock_file filter #593

merged 4 commits into from
Aug 25, 2022

Conversation

Pikabanga
Copy link
Contributor

@Pikabanga Pikabanga commented Aug 2, 2022

.NET supports lock files for Nuget packages since a few years ago, see https://devblogs.microsoft.com/nuget/enable-repeatable-package-restores-using-a-lock-file/

Without this filter detect-secrets flags a bunch of content hashes with the "Base64HighEntropyString" plugin.

Adding this file name to the filter removes the need for manually excluding these files (detect-secrets scan --exclude-files "packages\.lock\.json" > .secrets.baseline)

@lorenzodb1
Copy link
Member

Hi @Pikabanga, thank you for opening this PR. I appreciate your work on improving detect-secrets.

I ran our tests and it looks like they're failing, so I encourage you to take a look at those before we review your code. Let me know if you have any questions.

@Pikabanga
Copy link
Contributor Author

Pikabanga commented Aug 5, 2022

Hi @Pikabanga, thank you for opening this PR. I appreciate your work on improving detect-secrets.

I ran our tests and it looks like they're failing, so I encourage you to take a look at those before we review your code. Let me know if you have any questions.

The error is from a linter in files that I haven't touched...
image

But I can fix them if you want :)

@lorenzodb1
Copy link
Member

@Pikabanga, thank you for that! Could you please add the E275 fix as part of a separate PR? It would allow us to push that sooner, without having to push everything else you added in here.

@Pikabanga
Copy link
Contributor Author

Pikabanga commented Aug 5, 2022

@lorenzodb1 sure, here it is #598

@Pikabanga
Copy link
Contributor Author

Is this good to merge now? :)

Copy link
Member

@jpdakran jpdakran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you for your contribution.

@jpdakran jpdakran merged commit e61b9f9 into Yelp:master Aug 25, 2022
@Pikabanga Pikabanga deleted the pikabanga/add-dotnet-lockfile-to-is-lock-file branch August 25, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants