Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't filter out AWS access key ID with the ID filter #612

Merged

Conversation

nimrodkor
Copy link
Contributor

Fixes #608

@lorenzodb1 lorenzodb1 added false negatives P3 When you get around it. E.g. a fix for non-breaking issue we will work on when there's nothing more selected The issue has been selected to be worked on. and removed false negatives P3 When you get around it. E.g. a fix for non-breaking issue we will work on when there's nothing more selected The issue has been selected to be worked on. labels Sep 16, 2022
@lorenzodb1
Copy link
Member

Hi @nimrodkor, thank you for your PR! A few tests seem to be failing. If you could get all of them to pass, we will include your changes in the next release, which will be in two weeks. Let me know if there's anything I can help you with.

@nimrodkor
Copy link
Contributor Author

Hey @lorenzodb1 !
Thanks for your response, highly appreciated
I looked at the failing tests on TestYAMLTransformer - and I didn't touch this part. Furthermore, the test doesn't run code related to my change - it is failing to parse the yaml itself. I tried to test it on main - and it seems to still fail.
Can you verify the main branch is not failing on this as well?

@jpdakran
Copy link
Member

@nimrodkor Looks like this is the error output. Can you run pre-commit run --all-files to update the failing pre-commit hooks?

Reorder python imports...................................................Failed
- hook id: reorder-python-imports
- exit code: 1
- files were modified by this hook

Reordering imports in detect_secrets/filters/heuristic.py

Add trailing commas......................................................Failed
- hook id: add-trailing-comma
- exit code: 1
- files were modified by this hook

Rewriting tests/filters/heuristic_filter_test.py

@nimrodkor
Copy link
Contributor Author

Done, tnx @lorenzodb1 !

@nimrodkor
Copy link
Contributor Author

@jpdakran Fixed

@lorenzodb1 lorenzodb1 merged commit a12a15e into Yelp:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is_likely_id_string filter creates false negative in key scanning
3 participants