Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Release Process #625

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Improve Release Process #625

merged 2 commits into from
Oct 4, 2022

Conversation

jpdakran
Copy link
Member

@jpdakran jpdakran commented Oct 4, 2022

Problem:

  • When releasing detect-secrets - different deployers may get different results depending on env setup
  • Mainly revolving around if they are using a local copy of detect-secrets or not
  • When deploying we perform a commit - therefore we run pre-commit hook detect-secrets. Since in the commit we just updated the .secrets.baseline to a new version. If the installed version of detect-secrets is different - the hook will fail.

Solution:

  • When installing dependencies in the deploy process. Install a local copy of detect-secrets so there are no differences in .secrets.baseline upgraded version and old hook version.

@jpdakran jpdakran merged commit a293056 into master Oct 4, 2022
@lorenzodb1 lorenzodb1 deleted the dakranj-improve-release-process branch October 4, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants