Reduce sequential string false positives #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domanchi
approved these changes
Jul 31, 2018
| @@ -17,6 +17,12 @@ | |||
| from detect_secrets.plugins.core.yaml_file_parser import YamlFileParser | |||
|
|
|||
|
|
|||
| IGNORED_SEQUENTIAL_STRINGS = ( | |||
There was a problem hiding this comment.
Let's use the string library for this.
e.g.
import string
IGNORED_SEQUENTIAL_STRINGS = (
string.ascii_uppercase + string.digits + string.ascii_uppercase,
string.hexdigits + string.hexdigits,
)
There was a problem hiding this comment.
++
Changed it to
IGNORED_SEQUENTIAL_STRINGS = (
- 'ABCDEFGHIJKLMNOPQRSTUVWXYZABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789+/', # upper/lower, numbers +/
- '0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZABCDEFGHIJKLMNOPQRSTUVWXYZ+/', # numbers, upper/lower +/
- 'ABCDEFABCDEF0123456789ABCDEFABCDEF', # Hex
- 'ABCDEFGHIJKLMNOPQRSTUVWXYZ=/',
+ (
+ string.ascii_uppercase +
+ string.ascii_uppercase +
+ string.digits +
+ string.ascii_uppercase +
+ string.ascii_uppercase +
+ '+/'
+ ),
+ string.hexdigits.upper() + string.hexdigits.upper(),
+ string.ascii_uppercase + '=/',
)There was a problem hiding this comment.
I'm trying to use rebasing to make my commit history super clean, like someone I know. (@bcaller)
…ted tests to pass
KevinHock
force-pushed
the
62_reduce_sequential_false_positives
branch
from
15f3523
to
b5135fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.