Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop py36 support #672

Merged
merged 3 commits into from
Mar 28, 2023
Merged

Drop py36 support #672

merged 3 commits into from
Mar 28, 2023

Conversation

jpdakran
Copy link
Member

@jpdakran jpdakran commented Mar 27, 2023

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added
  • Docs have been added / updated
  • All CI checks are green
  • What kind of change does this PR introduce?
  • Feature
  • What is the current behavior?
  • Currently detect-secrets supports py36-39.
  • What is the new behavior (if this is a feature change)?
  • Drop py36 support as it has reached EOL on December 23, 2021.
  • Does this PR introduce a breaking change?
  • Yes. Upgrade python versions.
  • Other information:

@jpdakran jpdakran marked this pull request as ready for review March 27, 2023 17:37
@lorenzodb1
Copy link
Member

Should we add support for python 3.10 too?

@lorenzodb1
Copy link
Member

Also, fyi py37 EOL is set to be in three months (source), so let's keep that in mind too.

@jpdakran
Copy link
Member Author

@lorenzodb1 Yea good idea about py310. I just did a quick smoke test and there may be some dependency modifications. I'll make a note about it for a future issue - just to separate out the work.

@jpdakran jpdakran merged commit f43ca9f into master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants