Restrict Golang Keyword Detection #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er is optional. Specific for assignment and declaration in golang
Closed
lorenzodb1
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug Fix
What is the current behavior?
Issue was brought up that there are false positives for the goland keyword detector. This is verified since the regex that should be tracked - FOLLOWED_BY_COLON_EQUAL_SIGNS_REGEX - tracks
:=?assignment. Where the equal sign is optional. Therefore we detectkey: secret.What is the new behavior (if this is a feature change)?
The equal sign cannot be optional in golang. The
:=operator is used for assignment and declaration. This is what we are trying to track - not the possibility of:.Does this PR introduce a breaking change?
No