Account for Anchor & Alias Tags in yaml Transformer #679
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix - #632
There is an issue when the yaml transformer is parsing a yaml file.
Yaml has notions of anchor & and alias * tags. You can mark a section of code with an anchor tag and leverage it somewhere else in the yaml file with the * tags.
This causes duplicate lines in transformer which makes line numbers incorrect for the entire file.
When parsing through the yaml file. We keep the nodes as returned by pyyaml. However, when returning the lines from the transformer we trim our list to ignore duplicate line items. It is important we keep the ordering the same as we always want to return the first instance of a line and ignore the later references.
We a line item consists of (key, value, line_number, and line). We should not need to account for duplicates.
This will continue to account for duplicate key, value pairs that are on different lines.
No