Avoid IndexError when passing an empty string to is_prefixed_with_dollar_sign
#712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As shown by the test, we want to return False for the empty string when checking if it is prefixed with a dollar.
|
@sindrig thank you for your contribution 😄 could you please merge master into your branch? |
Done ✔️ |
|
@sindrig thank you for that! Looks like one of the pre-commit checks is failing. Please, run |
Import order got mixed up. Fixed ✅ |
lorenzodb1
approved these changes
Dec 18, 2023
lorenzodb1
changed the title
is_prefixed_with_dollar_sign
|
@sindrig Thank you for your contribution! I went ahead and merged your changes. Really appreciate your work and hope to see another PR of yours soon 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As shown by the test, we want to return False for the empty string when checking if it is prefixed with a dollar.
The function
is_prefixed_with_dollar_signraisesIndexErrorwhen called with the empty string.is_prefixed_with_dollar_signreturns False for the empty string.