Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include filename in error displayed if plugin file in baseline not found #719

Conversation

msabramo
Copy link
Contributor

@msabramo msabramo commented Oct 26, 2023

Fixes: #718

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added (see test_plugin_not_found_in_baseline in tests/core/baseline_test.py)
  • Docs have been added / updated
  • All CI checks are green
$ detect-secrets-hook --baseline .secrets.baseline setup.py
[initialize]	ERROR	Error: Failed to load `FakeCustomPlugin` plugin:
    [Errno 2] No such file or directory: './path/to/plugin/that/does/not/exist/plugin.py'
[initialize]	ERROR	This error can occur when using a baseline that references a custom plugin
    with a path that does not exist.
[scan]	ERROR	Unable to load plugins!
  • Does this PR introduce a breaking change?
    No

  • Other information:

@msabramo msabramo force-pushed the better-error-when-cant-find-plugin-referenced-in-baseline-file branch from 0a76035 to 1dae3f2 Compare October 26, 2023 18:26
@msabramo msabramo force-pushed the better-error-when-cant-find-plugin-referenced-in-baseline-file branch from 1dae3f2 to 82a6b6d Compare October 26, 2023 19:01
@msabramo msabramo changed the title Better error if plugin file in baseline not found Include filename in error displayed if plugin file in baseline not found Oct 26, 2023
@lorenzodb1
Copy link
Member

@msabramo thank you for your contribution 😄 I'm going to need you to merge master into your branch to run the latest version of our CI

@msabramo
Copy link
Contributor Author

@msabramo thank you for your contribution 😄 I'm going to need you to merge master into your branch to run the latest version of our CI

Sorry for the delay. Done in 3953579.

Copy link
Member

@lorenzodb1 lorenzodb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msabramo Thank you for your contribution! I'll go ahead and merge this PR 😄

@lorenzodb1 lorenzodb1 merged commit c4a8dbf into Yelp:master Apr 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should include filename in error displayed if plugin file in baseline not found
2 participants