Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit prompt wording #738

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Audit prompt wording #738

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f244ad
Reword audit prompt message for clarity
direvus Nov 20, 2023
c9e0beb
Update docs and tests for new prompt wording.
Nov 20, 2023
22463fe
Update prompt wording per request from @lorenzodb1
direvus Nov 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion detect_secrets/audit/io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def __init__(self, allow_labelling: bool, allow_backstep: bool) -> None:

def __str__(self) -> str:
if 'Y' in self.valid_input:
output = 'Is this a secret that should be committed to this repository?'
output = 'Should this be committed to the repository?'
direvus marked this conversation as resolved.
Show resolved Hide resolved
else:
output = 'What would you like to do?'

Expand Down
2 changes: 1 addition & 1 deletion docs/audit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Secret Type: Secret Keyword
68: }
69: ],
----------
Is this a secret that should be committed to this repository? (y)es, (n)o, (s)kip, (q)uit:
Should this be committed to the repository? (y)es, (n)o, (s)kip, (q)uit:
```

There are two common cases for manual labelling:
Expand Down
2 changes: 1 addition & 1 deletion tests/audit/io_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
'allow_backstep': True,
},
(
'Is this a secret that should be committed to this repository? '
'Should this be committed to the repository? '
'(y)es, (n)o, (s)kip, (b)ack, (q)uit: '
),
),
Expand Down
Loading