Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicer JSON output + exclude regex bug fix #78

Merged
merged 2 commits into from
Sep 28, 2018
Merged

Conversation

domanchi
Copy link
Contributor

[ 658ad0d ]
It always annoyed me that the JSON output from scan had trailing whitespace. However, looks like this is an old, known issue, that only happens in < Python 3.4, and the fix is merely to add that line to it.

[ 0a6f767 ]
Fix to minor bug I discovered:

$ cat .secrets.baseline
{
  "exclude_regex": "^.secrets.baseline$",
  ...
}
$ detect-secrets scan --update .secrets.baseline
$ cat .secrets.baseline
{
  "exclude_regex": "^.secrets.baseline$|^.secrets.baseline",
  ...
}

Copy link
Collaborator

@KevinHock KevinHock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KevinHock
Copy link
Collaborator

Squeaky clean commit history!

@domanchi domanchi merged commit 9445982 into master Sep 28, 2018
@domanchi domanchi deleted the nicer-json-output branch September 28, 2018 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants