Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use different regexes in KeywordDetector to improve accuracy #86

Merged
merged 19 commits into from
Jan 3, 2019
Merged

Use different regexes in KeywordDetector to improve accuracy #86

merged 19 commits into from
Jan 3, 2019

Commits on Oct 22, 2018

  1. Use different regexes in KeywordDetector to improve accuracy

    @KevinHock
    KevinHock committed Oct 22, 2018
    Configuration menu
    Copy the full SHA
    b9c80f9 View commit details
    Browse the repository at this point in the history

  2. Trim regexes down, include secret 'foo'; as well.

    @KevinHock
    KevinHock committed Oct 22, 2018
    Configuration menu
    Copy the full SHA
    c4e7676 View commit details
    Browse the repository at this point in the history

  3. Do not alert if whitespace is in secret

    @KevinHock
    KevinHock committed Oct 22, 2018
    Configuration menu
    Copy the full SHA
    fce2837 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2018

  1. [Keyword Plugin] Add 3 re's and their secret groups in dict

    @KevinHock
    KevinHock committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    3167cb1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into upgrade_keyword_detector

    @KevinHock
    KevinHock committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    b6dc9cc View commit details
    Browse the repository at this point in the history

  3. Add a few more Keyword negative test-cases

    @KevinHock
    KevinHock committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    b89209f View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2018

  1. Added a variety of accuracy improvements to Keyword Plugin (see tests) 

    Turned on Keyword detector by default
Down-graded version to '0.1.666' to test it on a few repos without causing havoc
    @KevinHock
    KevinHock committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    431ad12 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2018

  1. 🔭[Keyword Plugin] Filter false-positives 

    Filter out $variables for PHP files
Filter out `(|[` followed by `)|]`
Add `not`, more empty quotes and `password` variable names to FALSE_POSITIVES
    @KevinHock
    KevinHock committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    a27659a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into upgrade_keyword_detector

    @KevinHock
    KevinHock committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    a4c0432 View commit details
    Browse the repository at this point in the history

  3. 🐍 Make tests pass 

    After merging in master
    @KevinHock
    KevinHock committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    d8f4e29 View commit details
    Browse the repository at this point in the history

  4. 🐍 Improve test coverage 

    Trim uncovered code
Change tox to ensure tests are covered 100%
    @KevinHock
    KevinHock committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    ed6a374 View commit details
    Browse the repository at this point in the history

  5. 🔭[Keyword Plugin] Precision improvements 

    Removed `token` as a keyword
Made FOLLOWED_BY_EQUAL_SIGNS_RE require variable ends with keyword
    @KevinHock
    KevinHock committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    3fd9e87 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2018

  1. ⚡ Remove unnecessary wrapping parens 

    In keyword_test.py
    @KevinHock
    KevinHock committed Dec 21, 2018
    Configuration menu
    Copy the full SHA
    f15366e View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2018

  1. 🔭[Keyword Plugin] Precision improvements 

    Made quotes required in Python files/added regexes for this
Added a Filetype Enum and `determine_file_type` function

Replaced 'pass' with 'db_pass' in BLACKLIST
Added 'aws_secret_access_key' to BLACKLIST
Added some trailing char cases to FALSE_POSITIVES

:boom: Changed secret_type to 'Secret Keyword'
    @KevinHock
    KevinHock committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    e01d818 View commit details
    Browse the repository at this point in the history

  2. 🎓 Eg. -> E.g.

    @KevinHock
    KevinHock committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    4581aa8 View commit details
    Browse the repository at this point in the history

  3. 🔭[Keyword Plugin] Handle dict['keyword'] 

    By adding an optional `((\'|")])?` to the regexes
This is to catch 'foo' in e.g. `some_dict["secret"] = "foo"`
    @KevinHock
    KevinHock committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    b7e48ab View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2018

  1. 🔄 Merge branch 'master' into upgrade_keyword_detector

    @KevinHock
    KevinHock committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    a37a9c9 View commit details
    Browse the repository at this point in the history

  2. 🐍[consistency] 2 spaces before pragma comment

    @KevinHock
    KevinHock committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    d314550 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2019

  1. 🔭[Keyword Plugin] Precision improvements 

    Added Javascript specific false-positive checks
Added ${ before } heuristic for  e.g. ${link}
Added more false-positives to FALSE_POSITIVES

:zap: keyword_test.py
Make STANDARD_NEGATIVES list and STANDARD_POSITIVES set for DRYness
    @KevinHock
    KevinHock committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    a29108b View commit details
    Browse the repository at this point in the history